facebookresearch/ParlAI

DSTC7 teacher should be named Ubuntu_DSTC7

Open

#2,134 opened on Nov 6, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (10,371 stars) (2,089 forks)batch import
Help WantedMinordonotreap

Description

The name is misleading and confusing. We should rename it, and expand -t dstc7 to indicate ALL DSTC7 tasks.

Contributor guide

Tech stack
python
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Pythonfamiliarity with ParlAI teachers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Look for the DSTC7 teacher class in the ParlAI teachers directory, likely in `parlai/tasks/dstc7/teachers.py`. Rename the class from `DefaultTeacher` to `Ubuntu DSTC7Teacher` and update the corresponding entry in the task list. Also modify the ` t dstc7` command to include all DSTC7 tasks (e.g., DSTC7 Track 2). Search for references to 'dstc7' in the codebase to ensure consistency.