facebookresearch/HolisticTraceAnalysis

Why are there call_stack.py and trace_call_stack.py at the same time?

Open

#141 opened on May 20, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (94 forks)auto 404
help wantedneeds triagequestion

Repository metrics

Stars
 (535 stars)
PR merge metrics
 (PR metrics pending)

Description

What is your question?

The files HolisticTraceAnalysis/hta/common/call_stack.py and HolisticTraceAnalysis/hta/common/trace_call_stack.py, HolisticTraceAnalysis/hta/common/trace_call_graph.py seem to implement the same functionality, which is constructing call stack analysis for traces. Why is the same functionality implemented in two different places, even with the same classes? Which one is recommended officially?

Code

No response

What have you tried?

No response

Environment

No response

Contributor guide

Research direction
Compare the content and usage of call stack.py and trace call stack.py to identify any differences in functionality or purpose. Check the git history for their introduction and any related discussions or documentation.
Tech stack
pythonpytorch
Domain
developer experience
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75