fannkuch benchmark & implicit returns
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with fannkuch_static_basic_lib.py and reproduce the Cinder 3.10 error using the minimal main() example in the issue. Trace the implicit-return analysis for annotated functions with a while loop and conditional return, then verify that fannkuch and the small example compile without the erroneous TypedSyntaxError.
Written by the indexing model from the issue text.
Description
On Cinder 3.10, fannkuch_static_basic_lib.py gives a type error about implicitly returning None:
File "fannkuch_static_basic_lib.py", line 15
def fannkuch(n: int) -> int:
compiler.errors.TypedSyntaxError: Function has declared return type 'int' but can implicitly return None.
Here's a small program with the same error:
def main()->int:
while 1:
if 0:
pass
else:
return 4
main()
A quick fix is to add return 0 or something to the bottom of fannkuch. But maybe the implicit return analysis needs an upgrade.
cc @vivaan2006 who helped discover this
- Dominant language
- Python
- Stars
- 3.8k
- Forks
- 139
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from facebookincubator/MetaPython
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
facebookincubator/MetaPython#147 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
facebookincubator/MetaPython#146 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
facebookincubator/MetaPython#145 · 4 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 30/100
facebookincubator/MetaPython#144 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
facebookincubator/MetaPython#129 · 2 comments ·
All issues in facebookincubator/MetaPython
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
learningequality/ricecooker#747 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
BSData/horus-heresy-3rd-edition#3171 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
run-llama/llama_index#23199 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
KhronosGroup/glTF-Blender-IO#2769 ·