facebookexperimental/Recoil

[React Native] react-dom error on nightly build

Open

#755 opened on Nov 22, 2020

View on GitHub
 (13 comments) (1 reaction) (0 assignees)JavaScript (1,151 forks)batch import
help wanted

Repository metrics

Stars
 (19,428 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi there. I use recoil#nightly on react-native. It was not problem until now, but new version came out has a react-dom problem. May be below is affected.

https://github.com/facebookexperimental/Recoil/blob/nightly/native/recoil.js#L1

Contributor guide

Research direction
Inspect the nightly build file (native/recoil.js) to identify where react dom is imported, check if it's conditionally imported for web only, and propose a fix to guard it for React Native environments.
Tech stack
javascriptreactreact native
Domain
frontendmobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactReact NativeGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50