facebookexperimental/Recoil

[React Native] react-dom error on nightly build

Open

#755 opened on Nov 22, 2020

View on GitHub
 (13 comments) (1 reaction) (0 assignees)JavaScript (19,428 stars) (1,151 forks)batch import
help wanted

Description

Hi there. I use recoil#nightly on react-native. It was not problem until now, but new version came out has a react-dom problem. May be below is affected.

https://github.com/facebookexperimental/Recoil/blob/nightly/native/recoil.js#L1

Contributor guide

Tech stack
reactreact nativejavascript
Domain
frontendmobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic React Native knowledgeFamiliarity with Recoil
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue points to a react dom error in the nightly build of Recoil. Investigate the nightly build file at native/recoil.js to identify recent changes that introduced the dependency on react dom, which is not available in React Native. Look for a conditional import or a build time fix to exclude react dom when targeting React Native.