facebookexperimental/Recoil

Allow greater control in errorSelector

Open

#637 opened on Oct 7, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (19,428 stars) (1,151 forks)batch import
enhancementhelp wanted

Description

errorSelector currently takes a custom message as a parameter and passes that message into a newly constructed Error object.

Current: errorSelector("This is my error message")

I believe that asking for an Error object as the argument instead of a message would allow for greater control and flexibility.

Proposed: errorSelector(new Error("This is my error message")) Proposed:

errorSelector(() => { 
  let e = new Error(); 
  e.name = "AuthError"; 
  e.message = "User is not logged in"; 
  return e; 
})

If this is functionality that we would like to see in Recoil, I would love to submit a PR on this.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Recoil basicsError handling in JavaScriptWriting tests
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Wait for maintainer feedback on the proposed change. If approved, locate the errorSelector implementation in the Recoil source code, modify the function signature to accept an Error object or a factory function, update TypeScript typings, and add unit tests to ensure backward compatibility. Check if there are any existing tests related to errorSelector for reference.