facebookexperimental/Recoil

Memory leak when using atomFamily/selectorFamily

Open

#366 opened on Jun 19, 2020

View on GitHub
 (22 comments) (13 reactions) (1 assignee)JavaScript (1,151 forks)batch import
help wantedperformance

Repository metrics

Stars
 (19,428 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello there,

The resources created by atomFamily and selectorFamily are not being properly freed when the specific key changes or if the component using the related RecoilState<T> unmounts.

Since I believe that memory management isn't properly implemented yet, both utils should be marked as _UNSAFE.

https://codesandbox.io/s/cranky-booth-penix?file=/src/App.js

Contributor guide

Research direction
Investigate how atomFamily and selectorFamily manage resource allocation and cleanup. Trace the lifecycle when a component unmounts or key changes. Check if there is a missing cleanup in the family's internal map or if references prevent garbage collection. Look at the codesandbox to reproduce the memory leak.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30