facebookexperimental/Recoil

Feature Request: option to refresh to not recursively refresh all upstream selectors

Open

#1677 opened on Mar 17, 2022

View on GitHub
 (6 comments) (1 reaction) (0 assignees)JavaScript (19,428 stars) (1,151 forks)batch import
enhancementhelp wanted

Description

from the docs https://recoiljs.org/docs/api-reference/core/useRecoilRefresher

It is currently a no-op to "refresh" an atom, it will retain its current state. Selectors will have their caches cleared. Because wrapper selectors are often used as abstractions, refreshing a selector will also recursively refresh the caches of all selectors that it depends on.

However, if those upstream selectors have not changed but is used from the refreshed selector it will once again refresh and refetch (if doing some data fetching). IMO a good solution is an option that we can pass in to refresh to not refresh upstream selectors especially since its also a common use case. the current behavior would cause a cascade of refreshes when a lot of them are unnecessary

Contributor guide

Tech stack
reactjavascripttypescript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Recoil selectorsuseRecoilRefresher hookReact hooksCaching concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine Recoil's source code for the refresh mechanism, particularly the useRecoilRefresher hook and selector cache invalidation. Investigate how upstream selectors are recursively refreshed. Propose an API addition (e.g., a flag on the hook) to optionally disable recursive upstream refresh. Check the Recoil repository for any related discussions or prior attempts.