facebookexperimental/Recoil

[React Native] "Setting a timer for a long period of time" warning

Open

#1030 opened on May 16, 2021

View on GitHub
 (8 comments) (32 reactions) (0 assignees)JavaScript (19,428 stars) (1,151 forks)batch import
help wantednative

Description

Version 0.3.0 produces warning:

 WARN  Setting a timer for a long period of time, i.e. multiple minutes, is a performance and correctness issue on Android as it keeps the timer module awake, and timers can only be called when the app is in the foreground. See https://github.com/facebook/react-native/issues/12981 for more info.

Happens because of https://github.com/facebookexperimental/Recoil/blob/master/src/hooks/Recoil_Hooks.js#L60.

Any plans to fix it?

Contributor guide

Tech stack
javascriptreactreact native
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React Native basicsunderstanding of JavaScript timers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The warning occurs at https://github.com/facebookexperimental/Recoil/blob/master/src/hooks/Recoil Hooks.js#L60 due to a long timer. The fix involves replacing the timer with a React Native friendly approach, such as using InteractionManager.runAfterInteractions or a native module. Review the React Native issue linked (facebook/react native#12981) for guidance on avoiding this warning. The change is localized to a single file.