facebookarchive/prepack

Add test cases that exercise _withScope

Open

#871 opened on Aug 7, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
help wantedlevel 2 (easy)serializertest needed

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In src/serializer/ResidualHeapVisitor.js there are some this._withScope( calls in the visitor. Try to write test cases that fail if each of these lines is removed (e.g. in #868)

Contributor guide

Research direction
Examine the ` withScope` calls in `src/serializer/ResidualHeapVisitor.js` and write test cases that fail if those lines are removed.
Tech stack
javascript
Domain
tooling
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptTesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75