facebookarchive/prepack

Add test cases that exercise _withScope

Open

#871 opened on Aug 7, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import
help wantedlevel 2 (easy)serializertest needed

Description

In src/serializer/ResidualHeapVisitor.js there are some this._withScope( calls in the visitor. Try to write test cases that fail if each of these lines is removed (e.g. in #868)

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptPrepack internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine src/serializer/ResidualHeapVisitor.js, identify all ` withScope` calls, and write test cases that verify the correct behavior. Each test should fail when the corresponding ` withScope` line is removed, ensuring the calls are essential. Look at previous test patterns in the repository for guidance.
Add test cases that exercise _withScope · facebookarchive/prepack#871 | Good First Issue