facebookarchive/prepack

Make Prepack work for objects wrapping abstract value

Open

#838 opened on Jul 26, 2017

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (14,268 stars) (520 forks)batch import
abstractenhancementhelp wantedinterpreterserializer

Description

A simple testcase:

let x = global.__abstract ? __abstract("number", 42) : 42;
let y = Number(x);
inspect = function() {
  return y;
}

This should involve two changes:

  1. Make NumberValue/SymbolValue/StringValue/BooleanValue/ObjectValue able to wrap abstract value.
  2. Add serializer support for objects wrapping abstract value.

Contributor guide

Tech stack
javascript
Domain
toolingperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Prepack internalsJavaScript metaprogramming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue requires two changes: (1) Modify NumberValue/SymbolValue/StringValue/BooleanValue/ObjectValue to wrap abstract values, likely in the abstract value representation code. (2) Add serializer support for such wrapped objects, which involves the serializer module. Check the existing implementation of these value types and the serializer to understand current limitations. There are no comments or linked PRs, so start by examining the source files for these value types.