facebookarchive/prepack

Make Prepack work for objects wrapping abstract value

Open

#838 opened on Jul 26, 2017

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (520 forks)batch import
abstractenhancementhelp wantedinterpreterserializer

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

A simple testcase:

let x = global.__abstract ? __abstract("number", 42) : 42;
let y = Number(x);
inspect = function() {
  return y;
}

This should involve two changes:

  1. Make NumberValue/SymbolValue/StringValue/BooleanValue/ObjectValue able to wrap abstract value.
  2. Add serializer support for objects wrapping abstract value.

Contributor guide

Research direction
Study how abstract values are represented in Prepack and how wrapping functions like NumberValue work. Then implement support for wrapping abstract values in NumberValue/SymbolValue/StringValue/BooleanValue/ObjectValue and add serializer support for these wrapped objects.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30