facebookarchive/prepack

Enable fixed point checking in serializer tests for all cases

Open

#835 opened on Jul 25, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
design neededhelp wantedserializer

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently, fixed point checking is disabled in the serializer test runner (src/test-runner.js) when there are anyDelayedValues.

Search for a TODO with the text Make delayed initializations logic more sophisticated in order to still reach a fixed point..

The delayed initialization logic implemented in the serializer needs to be tweaked to avoid this significant weakening of the serializer tests.

Contributor guide

Research direction
Search for the TODO in src/test runner.js and modify the delayed initialization logic in the serializer to enable fixed point checking when anyDelayedValues are present.
Tech stack
javascript
Domain
tooling
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55