facebookarchive/prepack

Enable fixed point checking in serializer tests for all cases

Open

#835 opened on Jul 25, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import
design neededhelp wantedserializer

Description

Currently, fixed point checking is disabled in the serializer test runner (src/test-runner.js) when there are anyDelayedValues.

Search for a TODO with the text Make delayed initializations logic more sophisticated in order to still reach a fixed point..

The delayed initialization logic implemented in the serializer needs to be tweaked to avoid this significant weakening of the serializer tests.

Contributor guide

Tech stack
javascript
Domain
testingtooling
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptprepack codebaseserializer logic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The TODO in src/test runner.js with text 'Make delayed initializations logic more sophisticated in order to still reach a fixed point.' indicates that fixed point checking is disabled when there are anyDelayedValues. Investigate the serializer's delayed initialization logic and modify it to handle this case, then re enable fixed point checking for all tests. Look at the test runner and serializer implementation to understand the dependency.