facebookarchive/prepack

Deterministic timeout

Open

#719 opened on Jun 10, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
enhancementhelp wantedinterpreter

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Picking up a theme from #472 and #520 which warrants its own issue: It seems useful to reimplement the RealmOptions.timeout heuristic by counting evaluation operations, over the current nondeterministic approach of measuring wall-clock time.

@NTillmann per your earlier comments I gather you think Environment.prototype.evaluate would the right place to increment and check this proposed counter? If so, seems straightforward enough and I'll give it a go.

Contributor guide

Research direction
Inspect the Environment.prototype.evaluate function and implement a counter for evaluation operations to replace the wall clock timeout.
Tech stack
javascript
Domain
toolingbuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60