facebookarchive/prepack

Create smoke-test for prepack-node

Open

#693 opened on Jun 1, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
help wantedtest needed

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

A recent change to the code resulted in PrepackFile throwing an exception whenever it's invoked (see fix in #691 ), but that was not detected by any of our tests. We should add a basic smoke test for each of the exported functions from prepack-node (prepackStdin, prepackFile, and prepackFileSync) to allow for such clear-cut breaks to be automatically caught by testing.

Contributor guide

Research direction
Review the fix in PR #691 to understand the exception issue. Then create a smoke test file for prepack node that tests prepackStdin, prepackFile, and prepackFileSync with basic inputs to ensure they do not throw exceptions.
Tech stack
javascriptnodejs
Domain
testing qa
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70