facebookarchive/prepack

Bad command-line crashes Prepack

Open

#2509 opened on Aug 30, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import
bughelp wantedlevel 1 (super easy)priority: low

Description

This triggers an invariant violation.

node lib/prepack-cli.js --debugDiagnosticSeverity foo

It shouldn't. The command-line argument processing should rather print a user-friendly error message in such cases and exit, like it already happens for most or all other bad arguments.

Contributor guide

Tech stack
javascriptnodejs
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.jsbasic CLI knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Identify where command line arguments are parsed in lib/prepack cli.js or similar. Determine how other invalid arguments produce user friendly errors. Find the specific invariant violation triggered by bad debugDiagnosticSeverity and replace it with a proper error message and exit.