facebookarchive/prepack

Bad command-line crashes Prepack

Open

#2,509 opened on Aug 30, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
bughelp wantedlevel 1 (super easy)priority: low

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This triggers an invariant violation.

node lib/prepack-cli.js --debugDiagnosticSeverity foo

It shouldn't. The command-line argument processing should rather print a user-friendly error message in such cases and exit, like it already happens for most or all other bad arguments.

Contributor guide

Research direction
Find the command line argument parsing logic in the Prepack CLI code, likely in lib/prepack cli.js or similar, and add validation for the debugDiagnosticSeverity flag to print a user friendly error instead of triggering an invariant violation.
Tech stack
javascript
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80