facebookarchive/prepack

`__evaluatePureFunction` doesn't properly validate arguments

Open

#2385 opened on Aug 3, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import
bughelp wantedlevel 1 (super easy)

Description

Prepacking the following crashes Prepack.

__evaluatePureFunction("boo");

In the implementation, it shouldn't check via an invariant that the argument is a proper value, but instead it should throw a user-level exception or emit a CompilerDiagnostics error.

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptPrepack internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Search for ` evaluatePureFunction` in the codebase to locate the invariant check. Replace it with a proper error using CompilerDiagnostics or a user level exception, following existing error handling patterns in the repository.