facebookarchive/prepack

Revisit how source maps are installed

Open

#2366 opened on Aug 2, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import
design neededenhancementhelp wanted

Description

Since #2362, we allow for multiple source maps to be given. However, we also require that the basenames of source file and source map file match.

So, instead or in addition to supplying a list of file names, we could allow suppling one or many directories in which we'll look for matching source map files.

Or alternatively, the arguments given to Prepack could explicitly map individual source files to then arbitrarily names source map files.

Discuss...

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Knowledge of source mapsPrepack internals (source map installation)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
This issue proposes improving source map installation in Prepack. First, study PR #2362 to understand the current multiple source maps support. Then, explore file mapping strategies: either by scanning directories for matching basenames or by allowing explicit mapping via arguments. Discuss the trade offs in a follow up comment.