facebookarchive/prepack

realm.$TemplateMap is persistent throughout effects

Open

#2,129 opened on Jun 18, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
abstractbughelp wantedinterpreterlevel 2 (easy)

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Using ES2015 tagged template literals makes use of a $TemplateMap on the realm. When we evaluateForEffects and create a tagged template inside some effects, then revert the effects, it's expected that the newly created array objects in the template map are also stored on effects and properly reverted.

Contributor guide

Research direction
Examine how `realm.$TemplateMap` is managed during effect evaluation and revert. Look at the effect system's handling of arrays created for template literals.
Tech stack
javascript
Domain
compilerstooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25