facebookarchive/prepack

Make all files flow strict...

Open

#1,941 opened on May 11, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
help wantedrefactoring

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

... one by one.

Flow recently got a "strict" mode. We should make all our files "flow strict". This is the master issue to track progress until all files are flow strict.

We introduced flow strict to Prepack in #1692, and made the first file flow strict: https://github.com/facebook/prepack/pull/1692/files#diff-5c8b199a98cb05fcfa67ad0a331c165b

So, for each files, this starts by changing

* @flow */

to

* @flow strict */

and then fixing up the type errors (if any) that will emerge when running

yarn flow

One practical problem is that we have a giant cycle, and strict files can only import other strict files.

Contributor guide

Research direction
Select a file that is not yet flow strict, change its header from @flow to @flow strict, then run `yarn flow` to fix any type errors that arise. Ensure that all imported modules are also flow strict before proceeding.
Tech stack
javascript
Domain
tooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
FlowJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60