facebookarchive/prepack

Make all files flow strict...

Open

#1941 opened on May 11, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import
help wantedrefactoring

Description

... one by one.

Flow recently got a "strict" mode. We should make all our files "flow strict". This is the master issue to track progress until all files are flow strict.

We introduced flow strict to Prepack in #1692, and made the first file flow strict: https://github.com/facebook/prepack/pull/1692/files#diff-5c8b199a98cb05fcfa67ad0a331c165b

So, for each files, this starts by changing

* @flow */

to

* @flow strict */

and then fixing up the type errors (if any) that will emerge when running

yarn flow

One practical problem is that we have a giant cycle, and strict files can only import other strict files.

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptFlow type system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
This master issue tracks converting all Prepack files to Flow strict mode. The task involves changing @flow to @flow strict and fixing resulting type errors. The main challenge is a circular dependency between files that prevents strict mode propagation. The first conversion was done in PR #1692. Start by examining that PR and then pick a file outside the cycle to convert, or discuss with maintainers how to break the cycle. Since the repository is archived, further work may not be accepted.