facebookarchive/prepack

Adapt evaluators to deal with abstract conversion values

Open

#1,109 opened on Oct 27, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
abstracthelp wantedlevel 3 (medium)test needed

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The evaluators for binary and unary expression already have logic that allows them to deal with abstract operands. This does not cover the case where a concrete operand may become abstract after implicit conversion.

This pull request fixes this for the + operator: #1108. Follow that model for the other operators.

Contributor guide

Research direction
Examine pull request #1108 which implements the fix for the '+' operator, and apply the same pattern to other operators in the evaluators.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70