facebookarchive/prepack

Deal with abstract parent objects when creating new properties.

Open

#1,016 opened on Sep 27, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
abstractenhancementhelp wantedtest needed

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When running up the prototype chain for various operations, Prepack will stop with an error if an abstract object is encountered in the prototype chain. This is unnecessarily conservative, particularly if the parent object is a simple object.

Write some test cases with objects that have partial and partial+simple objects in their prototype chains and then create various kinds of properties on the objects.

Contributor guide

Research direction
Write test cases that create objects with partial and partial+simple objects in their prototype chains and verify property creation does not error.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65