facebookarchive/prepack

Produce abstract string for JSON.stringify(concreteObject) if properties are abstract

Open

#1,012 opened on Sep 27, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
abstractbughelp wantedtest needed

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If a concrete object has properties with abstract values, the interpretation of SerializeJSONProperty in src/intrinsics/ecma262/JSON.js will either fail obscurely or do the wrong thing, such as returning undefined.

It would be better to first check for this case and then go into the JSON.stringify part of the special case code for dealing with JSON.parse(JSON.stringify(abstractObject)).

Contributor guide

Research direction
Inspect the SerializeJSONProperty function in src/intrinsics/ecma262/JSON.js to understand how it handles abstract properties and modify it to produce an abstract string for the entire JSON.stringify call.
Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptJSON
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60