facebookarchive/prepack

Produce abstract string for JSON.stringify(concreteObject) if properties are abstract

Open

#1,012 opened on Sep 27, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import
abstractbughelp wantedtest needed

Description

If a concrete object has properties with abstract values, the interpretation of SerializeJSONProperty in src/intrinsics/ecma262/JSON.js will either fail obscurely or do the wrong thing, such as returning undefined.

It would be better to first check for this case and then go into the JSON.stringify part of the special case code for dealing with JSON.parse(JSON.stringify(abstractObject)).

Contributor guide

Tech stack
javascript
Domain
toolingbuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of JSON.stringifyfamiliarity with the prepack codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
The issue is in the archived facebookarchive/prepack repository, specifically in src/intrinsics/ecma262/JSON.js. The bug occurs in SerializeJSONProperty when a concrete object has abstract property values. To fix, first detect this case, then handle it similarly to the special case for JSON.parse(JSON.stringify(abstractObject)). Since the repo is archived, contributions may not be accepted, but the fix can be studied for learning.
Produce abstract string for JSON.stringify(concreteObject) if properties are abstract · facebookarchive/prepack#1012 | Good First Issue