facebookarchive/prepack

Deal with undefined properties in special case for JSON.parse(JSON.stringify(abstractObject))

Open

#1,011 opened on Sep 27, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
abstractenhancementhelp wantedserializertest needed

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If a known property of the abstractObject has an abstract value that may be undefined at runtime, then runtime code should be generated to delete (or not add) the property in the abstract value resulting from parse if the property value turns out to be undefined at runtime.

Contributor guide

Research direction
Examine how Prepack handles JSON.parse(JSON.stringify) on abstract objects, and implement runtime code to delete properties that are undefined.
Tech stack
javascript
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30