facebookarchive/prepack

Map NaN and Infinity to null in special case for JSON.parse(JSON.stringify(abstractObject))

Open

#1,010 opened on Sep 27, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
abstractenhancementhelp wantedtest needed

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If a property value is abstract can possibly be NaN or Infinity, then the abstract value should be wrapped in a conditional expression that returns null at runtime when the abstract values turns out to be NaN or Infinity at runtime.

Contributor guide

Research direction
Locate the code in Prepack that handles JSON.stringify for abstract objects. Add a check for NaN and Infinity values and replace them with null before serialization.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20