facebookarchive/prepack

Implement Date.prototype.toLocaleDateString/toLocaleString/toLocaleTimeString/toDateString

Open

#1,005 opened on Sep 27, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import
abstracthelp wantedinterpreterserializertest needed

Description

When running in abstract interpreter mode these calls should produce abstract strings to serialize to runtime calls.

When running in interpreter mode, just defer to the implementations of these functions in the JS engine running Prepack.

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingbackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Prepack's abstract interpreterKnowledge of JavaScript Date methodsFamiliarity with Prepack's codebase structureBasic understanding of JS runtime calls
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requires implementing four Date.prototype methods in Prepack's abstract interpreter and interpreter modes. In abstract mode, the methods should produce abstract strings that can be serialized to runtime calls. In interpreter mode, they should delegate to the native JavaScript implementations. Relevant code can be found in Prepack's source files handling built in objects, likely under src/abstract interpreter or src/runtime. Since the repository is archived, check for existing implementations of other Date methods as references.