facebookarchive/prepack

Use a much smaller upper limit for the size of the values domain of a binary operation

Open

#1,000 opened on Sep 26, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
abstractenhancementhelp wanted

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The maximum number of values that will be tracked in the ValuesDomain as the result of a binary operation or logical operation is currently 10 000. This is unlikely to be helpful. Add some instrumentation to get hold of the actual distribution of the sizes of value domains, given some relevant benchmarks, and then limit the size of the domain to the 99 percentile.

Contributor guide

Research direction
Analyze the code that computes the values domain for binary operations, add instrumentation to log the size distribution, run benchmarks, compute the 99th percentile, and adjust the limit accordingly.
Tech stack
javascript
Domain
compilers
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60