facebookarchive/draft-js

Changing customStyleMap doesn’t trigger re-render until contentState is changed

Open

#999 opened on Feb 7, 2017

View on GitHub
 (15 comments) (4 reactions) (0 assignees)JavaScript (2,646 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (22,554 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Do you want to request a feature or report a bug? Bug.

What is the current behavior? After customStyleMap is changed, nothing happens until contentState is changed.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem..

Check it out here: https://jsfiddle.net/m6z0xn4r/125/

What is the expected behavior?

#52 suggests that this exact problem has been cleared up. Regression?? Or am I not understanding how to do the thing?

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js? Latest, macOS, seems like all browsers. Dunno about previous versions.

Contributor guide

Research direction
Investigate the Draft.js Editor component's handling of customStyleMap prop updates. Check if componentDidUpdate or getDerivedStateFromProps properly triggers a re render when customStyleMap changes but contentState does not.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactDraft.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50