facebookarchive/draft-js

Edge case - Paste doesn't remove current selection before mouseup

Open

#991 opened on Jan 31, 2017

View on GitHub
 (4 comments) (1 reaction) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
bughelp wanted

Description

Do you want to request a feature or report a bug? Bug.

What is the current behavior? Editor does not remove selection when pasting unless mouseup has fired (it seems that a selection isn't registered until mouseup). I use a trackpad with 3 finger drag, which has a 300-ish millisecond delay after lifting. If I paste text in that window, the following behavior occurs:

draft-js

Basically, the repro steps are:

  1. Click and drag a selection
  2. Press cmd-P before mouseup

What is the expected behavior? Paste removes currently selected text (potentially not possible). Perhaps it could disallow pasting before mouseup?

Honestly, even OS X gets this wrong. Try the same steps on the location bar.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js? DraftJS: 0.10.0 Browser: Chrome 56 OS: Mac OS X 10.12.2

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactDraft.js basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue describes a bug where pasting text before mouseup does not remove the current selection. This is likely related to Draft.js clipboard handling in `DraftEditorPasteHandler` or `editOnPaste`. The fix may involve deferring paste action until selection is registered, or checking for selection state on paste. The repository is archived, so no maintainer response is expected.