facebookarchive/draft-js

Down arrow stops working after inserting link in Firefox

Open

#985 opened on Jan 31, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
bugfirefoxhelp wanted

Description

Do you want to request a feature or report a bug? Bug

What is the current behavior? When inserting a link in Firefox, the down arrow key stops working temporarily until a new selection has been made. Up, right and left arrow keys work as expected.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. https://jsfiddle.net/m6z0xn4r/116/

  1. Insert a few blank lines
  2. Add some text to the first line, and make it a link.
  3. Immediately after clicking 'Add Link', click the down arrow.

What is the expected behavior? Cursor to move down to the next line.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js? I'm able to reproduce this issue in Draft.JS 0.10.0 and 0.9.1 in Firefox (53.0). I've tested on Mac OS 10.12.3.

Contributor guide

Tech stack
javascriptreacthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of Draft.jsUnderstanding of browser keyboard eventsReact experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the keydown handler in Draft.js editor (likely in DraftEditor.js). The down arrow key event may be swallowed or selection not updated after link insertion in Firefox. Check for Firefox specific event handling differences. Use the provided jsfiddle to test fixes.