facebookarchive/draft-js

spellCheck and readOnly

Open

#780 opened on Nov 11, 2016

View on GitHub
 (7 comments) (1 reaction) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
help wanted

Description

Do you want to request a feature or report a bug? Bug What is the current behavior? I have a toggle to change draftjs window from editable to readonly. My editor is setup like so:

  <Editor
      editorState = {editorState}
      onChange = {this.onChange}
      handleKeyCommand={this.handleKeyCommand}
      onTab={this.onTab}
      spellCheck={!this.readOnly}
      readOnly={this.readOnly}
  />

The spell check works in editing mode (not-readonly). But when in readOnly mode (when the spellCheck should be disabled) it still shows spelling error.

**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started:

https://jsfiddle.net/q6ko96mv/1/

What is the expected behavior?

Spell check should be hidden.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

0.9.1

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactDraft.jsJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The bug is that the spellCheck prop is not disabled when readOnly is true. In Draft.js, the Editor component renders a contentEditable div. Investigate how the spellCheck prop is passed to that div. Possibly the prop is not being watched for updates or is only set on initial render. Look at the Editor component source to see if the spellcheck attribute is dynamically updated. The issue has comments suggesting workarounds; they may indicate a missing condition. A fix would likely involve updating the spellcheck attribute when the readOnly prop changes.