facebookarchive/draft-js

Cannot select all when last block is atomic

Open

#715 opened on Oct 14, 2016

View on GitHub
 (3 comments) (4 reactions) (0 assignees)JavaScript (2,646 forks)batch import
bughelp wanted

Repository metrics

Stars
 (22,554 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Do you want to request a feature or report a bug?

Report a bug.

What is the current behavior?

When the last (or first) block in the editor is atomic, it is not possible to use the Ctrl+A shortcut key to select all of the editor contents. Instead of selecting everything, the cursor moves to the beginning (or end, respectively) of the editor.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

See this fiddle: https://jsfiddle.net/robbertbrak/m52cpgnn/1/

What is the expected behavior?

I expect the 'select all' shortcut to work, regardless of what's in the editor.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

I'm using Draft 0.9.1. I could reproduce it with the latest Chrome and Firefox on Ubuntu 16.04, and MS Edge on Win10, but I think it is not browser dependent.

Contributor guide

Research direction
Investigate the editor's select all handler to understand why atomic blocks at the start or end break the selection. Check how Draft.js handles atomic block edges in the selection logic.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactDraft.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60