facebookarchive/draft-js

Cannot select all when last block is atomic

Open

#715 opened on Oct 14, 2016

View on GitHub
 (3 comments) (4 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
bughelp wanted

Description

Do you want to request a feature or report a bug?

Report a bug.

What is the current behavior?

When the last (or first) block in the editor is atomic, it is not possible to use the Ctrl+A shortcut key to select all of the editor contents. Instead of selecting everything, the cursor moves to the beginning (or end, respectively) of the editor.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

See this fiddle: https://jsfiddle.net/robbertbrak/m52cpgnn/1/

What is the expected behavior?

I expect the 'select all' shortcut to work, regardless of what's in the editor.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

I'm using Draft 0.9.1. I could reproduce it with the latest Chrome and Firefox on Ubuntu 16.04, and MS Edge on Win10, but I think it is not browser dependent.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactFamiliarity with Draft.js editor concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the selection logic in Draft.js, specifically how the 'select all' command is handled. The issue mentions that atomic blocks break the Ctrl+A shortcut. Look at the DraftEditor component and its keyBindingFn to see how it processes the select all command. Also examine the behavior of atomic blocks vs regular blocks in the editor's selection module. The provided jsfiddle (https://jsfiddle.net/robbertbrak/m52cpgnn/1/) can be used to reproduce the bug. Check if there are any existing fixes or discussions in the repository.