facebookarchive/draft-js

Do not default to LTR for empty editors

Open

#634 opened on Sep 7, 2016

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
bughelp wanted

Description

Do you want to request a feature or report a bug?

Reporting a bug, I guess.

What is the current behavior?

On an empty Draft.js field, the first block has a public-DraftStyleDefault-ltr class and the caret is on the left side. This is before the first character is typed. This default does not make sense for an RTL environment, where everything else is RTL except for the caret.

What is the expected behavior?

Not setting a direction when no content is available. It would default to the parent direction, which is a sensible default.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

Draft 0.8.1, Chrome 52 and Safari 9.1.3, OS X 10.11.16. Didn’t check the older versions.

I’d be happy to work on a PR if you agree with the suggestion.

Contributor guide

Tech stack
javascriptreact
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of Draft.js editor internalsUnderstanding of text direction handling in CSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The repository (facebookarchive/draft js) is archived, so no active development is expected. However, if one were to fix this, the issue is about the default LTR class applied to empty editor blocks. Investigate the logic in src/component/contents/DraftEditorBlock.react.js or similar files where block direction is determined. The fix would likely involve not applying a direction class when the block has no content, allowing the parent direction to take effect. Check for any existing PRs or comments that discuss the implementation.