facebookarchive/draft-js

Ctrl-K (Mac) should delete to newline, not block end

Open

#487 opened on Jun 25, 2016

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (22,554 stars) (2,646 forks)batch import
help wanted

Description

Usually blocks don't have newlines in them, but when they do (shift-enter in a list item, for example), Ctrl-K should delete to the newline, not the end of the block.

Also, Ctrl-K should delete an empty block.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of Draft.js editor behaviorFamiliarity with keyboard event handling in Draft.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the Draft.js source code for key binding handling, likely in `EditorState` or `RichUtils`. Look for how `Ctrl K` (or `Cmd K` on Mac) is currently implemented to delete to end of block, and modify the behavior to delete to newline instead. Check existing comments for any pointers or past attempts.