facebookarchive/draft-js

Out of sync selectionState within decorator strategy

Open

#484 opened on Jun 23, 2016

View on GitHub
 (4 comments) (1 reaction) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
help wantedquestion

Description

It would be nice for developers to be able to get the selectionState within a decorator strategy. When trying to do this with this.state.editorState.getSelection() inside of the decorator, the data seems to be out of sync.

Try creating a decorator with this strategy

strategy: (contentBlock, callback) =>  {
     const editorStateText = this.state.editorState.getCurrentContent().getPlainText();
     const contentBlockText = contentBlock.getText();

     console.log(editorStateText);
     console.log(contentBlockText);

     //...
},

You will notice that contentBlockText will be one character(or keystroke) ahead of editorStateText when typing.

Does getting an up-to-date selectionState within the decorator strategy seem like a good idea?

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Draft.js decorator strategiesUnderstanding of React stateJavaScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue describes a mismatch between the selectionState obtained inside a decorator strategy and the actual state. Investigate Draft.js source code for decorator strategy implementation, likely in src/component/decorators/. The problem may be that the strategy receives a snapshot of the editorState rather than the current one. A possible fix is to pass the latest editorState or provide a callback. Since the repository is archived, consider forking the project or exploring alternative text editors like Slate or Lexical.