facebookarchive/draft-js

Indenting list block of one type inside the other

Open

#443 opened on Jun 5, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
enhancementhelp wanted

Description

If I create a OL of 2 items and change depth of 2nd item to 2, like this:

1. ITEM1
      2. ITEM2

If I change type of 2nd item to UL it looses it depth:

1. ITEM1

2. ITEM2

But now if I try to indent second item, it works

1. ITEM1

    2. ITEM2

While indenting its checked that block above is list, but its not checked if its list of same type. Also, please find gif attached. I can create a PR for the fix.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of ReactFamiliarity with Draft.js editor internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Draft.js list indentation logic, specifically how block types are changed and depth is maintained. Look at the source files handling OL and UL block rendering, especially the 'RichTextEditor' or 'EditorState' utilities. The bug occurs when changing a list item type from OL to UL and the depth resets. Focus on the function that updates block type and its handling of depth. Examine the code in 'lib/EditorState.js' or similar that processes block metadata during type changes. The fix likely involves ensuring that the depth property is preserved when only the type field is modified.