facebookarchive/draft-js

Prints warnings when rendered within <React.StrictMode>

Open

#2,026 opened on Mar 6, 2019

View on GitHub
 (6 comments) (3 reactions) (0 assignees)JavaScript (2,646 forks)batch import
bugenhancementgood first issue

Repository metrics

Stars
 (22,554 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Do you want to request a feature or report a bug? Bug What is the current behavior? When rendering a draft editor as an ancestor of <React.StrictMode>, warnings are printed to the console about findDOMNode

image

What is the expected behavior? No warnings should be printed

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js? 0.11.0-beta All browsers

Contributor guide

Research direction
Replace findDOMNode with ref forwarding or callback refs to avoid React StrictMode warnings.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactDraft.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70