facebookarchive/draft-js

moveSelectionBackward warning in production

Open

#1,840 opened on Aug 20, 2018

View on GitHub
 (5 comments) (2 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
help wanted

Description

Do you want to request a feature or report a bug? bug

What is the current behavior? backspacing in the editor causes the following warning in dev environment:

Draft.js:5665 Warning: moveSelectionBackward should only be called with a collapsed SelectionState

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/stopachka/m6z0xn4r/.

  1. Open the official tweet.html example.
  2. Type "abcdefg"
  3. Press backspace Observe each time backspace is pressed there is a warning in the console log.

The warning is only shown in dev env. I haven't found any user facing issue caused by this.

What is the expected behavior? Shouldn't have warning in console log.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

There isn't this warning on the master of May 16, 2018, so it could be a regression.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Reactfamiliarity with Draft.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The warning 'moveSelectionBackward should only be called with a collapsed SelectionState' appears in dev mode in Draft.js. To investigate, search for the string 'moveSelectionBackward' in the source code. Look at the function that calls it and ensure it checks for collapsed selection before calling. The issue might be in the 'handleBackspace' or related method. Since the repository is archived, consider if a fix is still feasible or propose a workaround.