facebookarchive/draft-js

Test for indenting list item more than one level

Open

#1,674 opened on Mar 2, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,646 forks)batch import
good first issuehelp wantedtest coverage

Repository metrics

Stars
 (22,554 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

After we merge https://github.com/facebook/draft-js/pull/762 then Draft should support indentation of a list more than one item deep.

To make sure we don't regress this support in the future, let's add a test.

I would add a test in the suite of unit tests for RichEditorUtil, here -> https://github.com/facebook/draft-js/blob/master/src/model/modifier/__tests__/RichTextEditorUtil-test.js

We don't seem to have any test for 'onTab' so let's add one.

testing_i_love_testing

Contributor guide

Research direction
Write a unit test in RichTextEditorUtil test.js for the onTab method to verify that list items can be indented more than one level.
Tech stack
javascriptreact
Domain
frontend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80