facebookarchive/draft-js

Test for indenting list item more than one level

Open

#1674 opened on Mar 2, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
good first issuehelp wantedtest coverage

Description

After we merge https://github.com/facebook/draft-js/pull/762 then Draft should support indentation of a list more than one item deep.

To make sure we don't regress this support in the future, let's add a test.

I would add a test in the suite of unit tests for RichEditorUtil, here -> https://github.com/facebook/draft-js/blob/master/src/model/modifier/__tests__/RichTextEditorUtil-test.js

We don't seem to have any test for 'onTab' so let's add one.

testing_i_love_testing

Contributor guide

Tech stack
reactjavascript
Domain
frontendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Draft.js editorFamiliarity with unit testing in React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the linked PR #762 to understand the expected behavior for indenting list items more than one level. Then, open the file 'src/model/modifier/ tests /RichTextEditorUtil test.js' and add a new test case for the 'onTab' function. Follow the existing test patterns to ensure the test passes and covers the scenario.