facebookarchive/draft-js

Test to verify focus/scroll behavior

Open

#1402 opened on Sep 22, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
help wantedtest coverage

Description

We have twice now had an issue where a change in Chrome breaks the scroll/focus behavior of Draft. See issues #14 and now https://github.com/facebook/draft-js/issues/1381.

It might not be easy, but I'd really like to get this covered by a test, so that we can know if/when it breaks again. Ideally would like both a unit test for focusNode in fbjs and a test that only uses the public API of Draft.js and reproduces an example similar to the one given in https://github.com/facebook/draft-js/issues/1381 .

It's true that these test would only start failing when run in the browser that has the inconsistency, but still would make it faster to verify and fix this type of problem.

Contributor guide

Tech stack
javascriptreact
Domain
frontendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Draft.js public APIExperience with unit testing frameworksKnowledge of browser scroll/focus behavior
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests two tests: a unit test for `focusNode` in fbjs (https://github.com/facebook/fbjs/blob/master/packages/fbjs/src/core/dom/focusNode.js) and a test using Draft.js public API to reproduce the scroll/focus issue from #1381 (https://github.com/facebook/draft js/issues/1381). Look at the linked issues #14 and #1381 for reproduction steps. The tests should be added to the Draft.js test suite. Since the repo is archived, ensure compatibility with existing test infrastructure.