facebookarchive/draft-js

Why is createEntity mutable?

Open

#1,256 opened on Jun 21, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,646 forks)batch import
documentationhelp wanted

Repository metrics

Stars
 (22,554 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Do you want to request a feature or report a bug? Question/bug

What is the current behavior? Calling contentState.createEntity actually modifies contentState object instead of just returning a new one. Here is a simple fiddle: https://jsfiddle.net/FredyCr/32vo35tk/2/

What is the expected behavior? I guess it's not a big deal, it's just little bit confusing given that almost every other operation is immutable.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js? Working with the latest 0.10.1, not sure about previous versions.

Contributor guide

Research direction
Examine the createEntity method in Draft.js source to determine if the mutation is intentional or a bug. Check if there is a documented reason or if it's an oversight. Then provide guidance on how to work around it or file a fix.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReactDraft.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60