facebookarchive/draft-js

Draft breaks when pressing enter on atomic block

Open

#1191 opened on May 4, 2017

View on GitHub
 (4 comments) (8 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
documentationgood first issue

Description

Do you want to request a feature or report a bug? BUG

What is the current behavior? When the Image is not 100% wide in the editor and you focus cursor after it and press enter you get.

invariant.js:44 Uncaught Invariant Violation: Unknown DraftEntity key.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/stopachka/m6z0xn4r/.

In Media example remove the width styles like showed below. https://github.com/facebook/draft-js/compare/master...leniartek:patch-1 Than place the cursor after image and press enter. image

What is the expected behavior?

Enter to create a empty new line after image.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

all draft versions all browsers

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of Draft.jsReact experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The bug occurs when pressing Enter after an atomic block (e.g., image) that is not 100% wide, causing an 'Unknown DraftEntity key' invariant. The issue includes a jsfiddle and a patch (https://github.com/facebook/draft js/compare/master...leniartek:patch 1) that removes width styles to reproduce. To fix, investigate how Draft.js handles atomic blocks on Enter key press, particularly the removal of the entity key. The repository is archived, so any fix would need to be submitted to a fork.