facebookarchive/draft-js

EditorState.set() Selection Handling

Open

#1161 opened on Apr 22, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
documentationhelp wanted

Description

Do you want to request a feature or report a bug?

Bug (or documentation issue)

What is the current behavior?

EditorState.set() doesn't handle selection.

Steps to reproduce: https://jsfiddle.net/7bsqzmfg/10/

What is the expected behavior?

Either EditorState.set() should handle selection or we should mention that it is not supposed to handle selection on the docs.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

Draft.js 0.10.0 Google Chrome 57.0.2987.133 macOS Sierra 10.12.3 (16D32)

Contributor guide

Tech stack
javascriptreact
Domain
frontenddocumentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of ReactFamiliarity with Draft.js EditorState
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue reports that EditorState.set() does not handle selection, with a reproduction in JSFiddle. The repository is archived (facebookarchive/draft js), so any fix would need to be applied to a fork. To proceed, locate the EditorState.set() method in the source (likely src/model/immutable/EditorState.js) and examine how selection is currently handled. Check if the method should preserve selection from the previous state or if the documentation should clarify that selection is not handled. Also review any existing comments in the issue or related issues. Consider both fixing the behavior and updating documentation accordingly.