facebookarchive/draft-js

Improve style by removing boolean param in `getCharacterRemovalRange.js`

Open

#1116 opened on Apr 3, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
enhancementgood first issue

Description

A recent change added two boolean flag params to getCharacterRemovalRange.js. Boolean params generally make code less readable and maintainable - this is not worth blocking a PR at this time, but it would be great to update this file and the callsites to call two methods instead of passing in different boolean params.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJavaScriptfamiliarity with draft js codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the changes in PR #1108 that added boolean params to getCharacterRemovalRange.js. Then refactor the function to split into two methods (e.g., for forward and backward deletion) and update all callsites. Ensure existing tests pass and add tests if needed. See issue comments for discussion.