facebookarchive/draft-js

Improve style by removing boolean param in `getCharacterRemovalRange.js`

Open

#1,116 opened on Apr 3, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,646 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (22,554 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

A recent change added two boolean flag params to getCharacterRemovalRange.js. Boolean params generally make code less readable and maintainable - this is not worth blocking a PR at this time, but it would be great to update this file and the callsites to call two methods instead of passing in different boolean params.

Contributor guide

Research direction
Identify the boolean parameters in getCharacterRemovalRange.js, create two separate functions without boolean flags, and update all call sites to use the appropriate one.
Tech stack
javascriptreact
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80