facebookarchive/caffe2

Segfaults if GivenTensorFill shape doesn't match actual floats

Open

#1,426 opened on Nov 3, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Shell (1,954 forks)batch import
bughelp wanted

Repository metrics

Stars
 (8,424 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It shouldn't do that.

Repro steps:

  1. Make a GivenTensorFill. Set its shape to something big, give it only one value in floats
  2. Run it

Expected result: validation failure Actual result: segfault

Contributor guide

Research direction
Inspect the validation of shape parameters in GivenTensorFill operator and add proper error handling to prevent segfault when shapes mismatch.
Tech stack
cpppython
Domain
machine learningai
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50