facebookarchive/bootstrapped

Num / Denom samples can be different records

Open

#10 opened on May 27, 2017

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Python (622 stars) (105 forks)batch import
enhancementhelp wanted

Description

https://github.com/facebookincubator/bootstrapped/blob/master/bootstrapped/bootstrap.py#L78

Make this function return both numerator and denominator values so that the sampled indexes are aligned

Contributor guide

Tech stack
python
Domain
data
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Pythonbasic understanding of bootstrapping
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests modifications to the `bootstrap` function at line 78 in bootstrapped/bootstrap.py. The function currently returns only denominator samples? The task is to modify it to return both numerator and denominator so that sampled indexes are aligned. Check the current implementation and any test files for verification. Note that the repository is archived under facebookarchive, so contributions may not be accepted.