facebookarchive/atom-ide-ui

Datatip source code links

Open

#183 opened on Mar 6, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (110 forks)batch import
datatipshelp wanted

Repository metrics

Stars
 (937 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

I have put a source link in the markdown contents of a datatip. Namely the Atom Core URL to open a file in Atom editor given its path: [This is a link](atom://core/open/file?filename=<path to file>) Atom Core links went in with #15935. I have also opened the same issue against core Atom #16888 I'm not exactly sure which package is responsible for this to work...

The problem is that ATom URL handlers are not supported in MD datatip/hover or any rendered MD

Expected Behavior

Should invoke Atom URL handler for atom:// URL

Actual Behavior

Nothing happens. Expects a http:// protocol which is handled by opening external browser

Versions

  • Atom: 1.25-beta2 and all predecessors
  • Client OS: Mac OSX
  • atom-ide-ui: 0.9.2

Additional Details

Looking for directions... What to look at if I am to provide a patch for this

Contributor guide

Research direction
Investigate how Atom handles custom URL schemes in markdown rendering. Look at the Datatip component and the markdown renderer to see how URLs are processed. Check if there is a URL handler registry and how to register atom:// links.
Tech stack
javascript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65