facebookarchive/atom-ide-ui

Misplaced gutter icons

Open

#108 opened on Oct 31, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (937 stars) (110 forks)batch import
diagnosticshelp wanted

Description

Description

Gutter icons from the diagnostics module pop up to the left of line numbers. In fact, while no icons are visible it looks fine, as soon as a warning pops up, the whole line number row is moved to the right to make space for the icons. Not super important, but I find the way the linter package does it to be way more pleasant to the eye.

Expected Behavior

Actual Behavior

Versions

  • Atom: 1.21.1
  • Client OS: macOS High Sierra 10.13
  • atom-ide-ui: 0.5.3

Contributor guide

Tech stack
javascriptcsshtml
Domain
frontenddesign
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSDOM
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the diagnostics module's gutter icon implementation. Look for files related to gutter or line numbers, such as 'gutter.js' or 'diagnostics.js' in the atom ide ui package. Check how the linter package handles gutter icons for reference. Inspect CSS rules that position gutter icons relative to line numbers.