facebookarchive/Keyframes

Documentation: Explain about decoding JSON in the background

Open

#103 opened on Jan 12, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (304 forks)batch import
do-not-reaphelp wanted

Repository metrics

Stars
 (5,337 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hey guys,

Using the Android library here. When loading large json files, I'm getting around a 2-3 second UI hang. This was obviously undesired and I narrowed down the issue to being in the deserialization of the asset from the InputStream. The way I got around the issue was by using an Rx chain and pushing the deserialization off of the UI thread while providing a Looper from a HandlerThread to the Scheduler. I'm sure this can be achieved in a similar fashion with AsyncTask if needed.

In general, the file still takes around 2 seconds to load while on a background thread. Our animation files are around 30k - 50k lines long.

Contributor guide

Research direction
Investigate how to perform JSON deserialization off the UI thread in the Keyframes Android library, and document the recommended approach using AsyncTask or RxJava.
Tech stack
androidjava
Domain
mobile
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android developmentBackground threading
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75