facebook/zstd

mingw library cross-compilation

Open

#1,911 opened on Nov 28, 2019

View on GitHub
 (4 comments) (0 reactions) (1 assignee)C (27,100 stars) (2,481 forks)batch import
help wanted

Description

#1910 adds mingw cross compilations, and tests it in CI. But only CLI generation is tested.

The issue is, library compilation generates warnings related to -fPIC compilation flag. Since tests follow a zero-warning policy, running such a test would break CI.

The goal is to find a way to cross-compile libzstd with mingw without generating warnings.

Contributor guide

Tech stack
c
Domain
build systeminfrastructure
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C programmingunderstanding of makefilescross compilation conceptsmingw environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
First, examine the existing PR #1910 to understand how mingw cross compilation is set up for CLI. Then look at the library build process, likely in Makefile or CMakeLists.txt, to identify where fPIC flag is added and why it causes warnings for mingw. The goal is to conditionally disable fPIC for Windows targets (mingw) without affecting other platforms. Ensure that the CI test for library compilation is also added.