facebook/stetho

App crashes when Stetho is open during a screen rotation

Open

#534 opened on May 5, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Java (12,643 stars) (1,163 forks)batch import
help wanted

Description

This is running on a Genymotion 2.9.0 VM, Android N. Stetho 1.5.0 The app is using AppCompat 25.3.1.

Stacktrace:

java.lang.IllegalStateException: Fragment has not been attached yet.
    at android.support.v4.app.Fragment.instantiateChildFragmentManager(Fragment.java:2154)
    at android.support.v4.app.Fragment.getChildFragmentManager(Fragment.java:704)
    at com.facebook.stetho.common.android.FragmentCompatSupportLib$FragmentAccessorSupportLib.getChildFragmentManager(FragmentCompatSupportLib.java:101)
    at com.facebook.stetho.common.android.FragmentCompatSupportLib$FragmentAccessorSupportLib.getChildFragmentManager(FragmentCompatSupportLib.java:68)
    at com.facebook.stetho.common.android.FragmentCompatUtil.findFragmentForViewInFragment(FragmentCompatUtil.java:120)
    at com.facebook.stetho.common.android.FragmentCompatUtil.findFragmentForViewInFragmentManager(FragmentCompatUtil.java:99)
    at com.facebook.stetho.common.android.FragmentCompatUtil.findFragmentForViewInActivity(FragmentCompatUtil.java:83)
    at com.facebook.stetho.common.android.FragmentCompatUtil.findFragmentForViewInActivity(FragmentCompatUtil.java:56)
    at com.facebook.stetho.common.android.FragmentCompatUtil.findFragmentForView(FragmentCompatUtil.java:46)
    at com.facebook.stetho.inspector.elements.android.ViewGroupDescriptor.getElementForView(ViewGroupDescriptor.java:76)
    at com.facebook.stetho.inspector.elements.android.ViewGroupDescriptor.onGetChildren(ViewGroupDescriptor.java:47)
    at com.facebook.stetho.inspector.elements.android.ViewGroupDescriptor.onGetChildren(ViewGroupDescriptor.java:27)
    at com.facebook.stetho.inspector.elements.AbstractChainedDescriptor.getChildren(AbstractChainedDescriptor.java:118)
    at com.facebook.stetho.inspector.elements.Document.createShadowDocumentUpdate(Document.java:307)
    at com.facebook.stetho.inspector.elements.Document.updateTree(Document.java:341)
    at com.facebook.stetho.inspector.elements.Document.access$1200(Document.java:31)
    at com.facebook.stetho.inspector.elements.Document$ProviderListener.onPossiblyChanged(Document.java:720)
    at com.facebook.stetho.inspector.elements.android.AndroidDocumentProvider$1.run(AndroidDocumentProvider.java:71)
    at android.os.Handler.handleCallback(Handler.java:751)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:154)
    at android.app.ActivityThread.main(ActivityThread.java:6077)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android developmentFragment lifecycleStetho basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The crash occurs when Stetho tries to access the child fragment manager during screen rotation, but the fragment hasn't been attached yet. The stack trace indicates the issue is in FragmentCompatSupportLib.java (getChildFragmentManager) and related classes. Investigate how Stetho handles fragment lifecycle events, particularly in FragmentCompatUtil.findFragmentForViewInFragment. A potential fix could be to add a null check or ensure the fragment is attached before accessing its child fragment manager. Also check if there are any recent changes or discussions in the comments.