facebook/stetho

Runtime#getProperties returns empty array when ownProperties == false

Open

#365 opened on Mar 18, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (12,643 stars) (1,163 forks)batch import
help wanted

Description

According to the protocol, Runtime#getProperties contains a parameter ownProperties with the following documentation: If true, returns properties belonging only to the element itself, not to its prototype chain.. While it's not clear what happens if ownProperties is false, I assume it should return all properties (not just it's own properties). However, Stetho is currently returning an empty array. When I connected to ChromeDevTools, it passes false for this value, meaning nothing is showing up in Scope Variables view.

Contributor guide

Tech stack
java
Domain
mobileapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaChrome DevTools protocol basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the implementation of Runtime.getProperties in Stetho's CDP handler (likely in a Java class under the 'runtime' package). The protocol JSON indicates that when ownProperties is false, all properties including prototype chain should be returned. Currently it returns empty array. Look for the method that builds the property list and ensure it iterates over the entire prototype chain when ownProperties is false. Reference the protocol JSON from the Stetho repository.