facebook/stetho

Runtime#getProperties returns empty array when ownProperties == false

Open

#365 opened on Mar 18, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (1,163 forks)batch import
help wanted

Repository metrics

Stars
 (12,643 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

According to the protocol, Runtime#getProperties contains a parameter ownProperties with the following documentation: If true, returns properties belonging only to the element itself, not to its prototype chain.. While it's not clear what happens if ownProperties is false, I assume it should return all properties (not just it's own properties). However, Stetho is currently returning an empty array. When I connected to ChromeDevTools, it passes false for this value, meaning nothing is showing up in Scope Variables view.

Contributor guide

Research direction
Examine the protocol documentation for getProperties. Trace the Java code path that handles 'ownProperties' parameter. Ensure that when ownProperties is false, all properties including prototype properties are returned. Implement the missing logic for returning prototype properties.
Tech stack
java
Domain
mobile devtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJavaAndroid development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60